refactor(IShare): Add typing for IShare #57575
Open
+178
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
carl/typing-share
branch
from
c63846f to
7ae0c6f
Compare
CarlSchwan
force-pushed
the
carl/typing-share
branch
from
7ae0c6f to
c9ff2e8
Compare
CarlSchwan
requested review from
ArtificialOwl,
come-nc,
leftybournes and
provokateurin
and removed request for
a team
CarlSchwan
changed the title
Merged
Altahrim
approved these changes
Jan 16, 2026
CarlSchwan
force-pushed
the
carl/typing-share
branch
3 times, most recently
from
98b5b77 to
8b6715c
Compare
This might also improve a bit the performance. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/typing-share
branch
from
8b6715c to
cec0a3b
Compare
Member
Author
Yeah feels tiny to risky to do that in 33. Not worth the tiny performance improvements |
Comment on lines
+254
to
+259
| try { | ||
| $share->getId(); | ||
| $this->fail(); | ||
| } catch (LogicException $e) { | ||
| // object is expected to not have been created | ||
| } |
Member
There was a problem hiding this comment.
Could also assert that the exception is thrown ($this->expectException).
Comment on lines
+94
to
+96
| if ($this->id === null) { | ||
| throw new \LogicException('Share id is null'); | ||
| } |
Member
There was a problem hiding this comment.
This might break apps. IIRC I tried to add typing to IShare once and some apps rely on getting null back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This might also improve a bit the performance as we are spending 2-3% of CPU time in
IShare::setIdTODO
Checklist
3. to review, feature component)stable32)